Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rpath on webOS, make SDL2 lib copy optional #16294

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix rpath on webOS, make SDL2 lib copy optional #16294

merged 1 commit into from
Feb 27, 2024

Conversation

csdougliss
Copy link
Contributor

Description

  • rpath added in previous PR did not work as $ORIGIN was interpreted as an environment variable
  • sdl2 library in buildroot may cause issues depending on users version so make it optional

Reviewers

@zoltanvb

@csdougliss csdougliss changed the title Fix rpath on webOS Fix rpath on webOS, make SDL2 lib copy optional Feb 26, 2024
@zoltanvb
Copy link
Contributor

Thanks for the ping, but I am not really familiar with WebOS specifics. Anyway this change should have no effect on other builds.

@LibretroAdmin LibretroAdmin merged commit 2e710f4 into libretro:master Feb 27, 2024
25 of 26 checks passed
Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this pull request Dec 26, 2024
@csdougliss @Sunderland93
Fix rpath on webOS and making sdl2 lib copy optional (libretro#16294)
85e55a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csdougliss @zoltanvb @LibretroAdmin