Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RETRO_ENVIRONMENT_GET_SYSTEM_DIRECTORY to work around problems wi… #22

Closed
wants to merge 1 commit into from

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Jan 20, 2017

…th the savedir.

Since 2048 doesn't have any content it has problems with the RetroArch save directory. This is especially apparent when cores are installed to read only directories through a distro's package management. 2048 will either then try to save to a read only directory which won't work or the save will end up in the wrong place if used with Sort Saves In Folders. For example I found in my 2048.srm in the GLupeN64 save directory.

So I looked at Craft which also does not have any content and found it uses RETRO_ENVIRONMENT_GET_SYSTEM_DIRECTORY instead. So while this may not be an ideal solution, it works much better for now and will be trivial to change back if and when the save directory behavior is improved.

Please also see issue #4.

@Alcaro
Copy link
Contributor

Alcaro commented Jan 21, 2017

Working around front bugs in the core? That way likes spaghetticode and cores that don't work in other fronts. We may not get there this fast, but we get closer, and I don't like that idea.

@orbea
Copy link
Contributor Author

orbea commented Jan 21, 2017

Fair enough, this can be closed then and a better solution can be found later. Do you also have a problem with cores like Craft using the system directory?

I've made an issue report for RA.
libretro/RetroArch#4473

@orbea orbea closed this Jan 21, 2017
@orbea orbea deleted the savedir branch January 21, 2017 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants