Fixes for eternall.wad and musinfo #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 7 alerts when merging 0d92eaa into ae95543 - view on LGTM.com fixed alerts:
|
|
I've also routed the logging functions to the libretro |
|
This pull request fixes 7 alerts when merging d80b4c6 into ae95543 - view on LGTM.com fixed alerts:
|
If a token is the last in the input (there's no ending newline) the token was never being read.
|
This pull request fixes 7 alerts when merging 0d955dd into ae95543 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of fixes.
One is the scalestep for drawsegs being uninitialized in some wads like
eternall.wad(from Eternal Doom PWAD, not to be confused with Doom Eternal :P), which I noticed when checkin it through valgrind (related to #118, and maybe it can fix it).I also fixed some oversights on my part when I made the MUSINFO parsing reuse the same scanner as UMAPINFO, and some warnings found by LGTM.