[SDL2][PSP] Allow to use ShowMessageBox without window
#10580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @erysdren as he was original MessageBox implementation |
fjtrujy
force-pushed
the
psp/sdl2ShowMessageNoWindow
branch
from
1f034f9
to
7543a6f
Compare
|
I have also tested it in real PSP hardware and there everything worked fine, even the wrong unicode text we can see in the previous screenshots from PPSSPP. Cheers |
|
@slouken feel free to merge this PR! |
|
Merged! |
|
Can this work on other platforms? SDL2 MessageBoxes on Steam Deck (when running as a Windows executable) don't appear for me and I haven't got to the bottom of why (running with just SDL_WINDOW_SHOWN) flag on the window. |
|
Have you already done similar work for SDL3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to show message box even if there are no windows created.
In order to make this work we are now creating a temporal GU context if there is no window created.
Some other changes have been done:
src/render/psp/SDL_render_psp.hSDL_pspmessageboximplementation toSDL_pspvideo.cThe
test/testmessage.cexample works as expected now.