render: remove logical presentation render target #10867
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still totally busted even for simple cases, but here's testspriteminimal mostly working:
This isn't ready to merge, but it's been radio silence for way too long, so I'm putting it in a draft PR.
I spent time trying a few different approaches:
The current approach tries to use a seperate SDL_RenderViewState to manage logical presentation, and this seems to work without a lot of code changes, but some math is wrong somewhere, still. There's a lot of state management that needs to be examined at the edges anyhow, like when a resize event comes through and possibly wipes out some view state, etc.
Also, if the app sets a viewport or scale of its own, it's going to cause problems, but eventually that would be managed as separate value that we just multiply in to the final calculation, but I need to get the math right on the normal codepath before I worry about that.
(eventually) Fixes #8736.