Don't call GetMessageTime on Xbox platforms #10909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a compilation issue due to the GAMES partition of WinAPI not including GetMessageTime
|
Merged, thanks! |
|
release-2.30.x branch needs this too, yes? |
|
I imagine so, yes. if you want it, I have a patch that works on top of 2.30.7 |
|
It doesn't cleanly cherry pick, and I haven't had time to look at why. I'll probably work on a 2.32 release next month, so it isn't urgent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contents of
winuser.hare generally not available when targetingWINAPI_PARTITION_GAMES.Don't compile the call to
GetMessageTimeon Xbox, fixes a build failure.Existing Issue(s)
22c1444breaks compiling for WINAPI_PARTITION_GAMES (Xbox) #10159