Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to check the state of a thread #11717

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

Mori-TM
Copy link
Contributor

@Mori-TM Mori-TM commented Dec 25, 2024

Description

SDL_GetThreadState returns the current state of a thread as enum SDL_ThreadState, which is now also accessible for the user.

  • Added SDL_GetThreadState
  • Moved SDL_ThreadState from SDL_thread_c.h -> SDL_thread.h
  • The "available since" version might not be correct on the new function and the old enum

Existing Issue(s)

#11702

@slouken slouken requested a review from icculus December 25, 2024 20:17
@slouken
Copy link
Collaborator

slouken commented Dec 25, 2024

This seems good to me, though I might remove _STATE from the enum values. @icculus, thoughts?

@icculus
Copy link
Collaborator

icculus commented Dec 25, 2024

Agreed, let's drop _STATE. But otherwise, I'm on board.

@icculus
Copy link
Collaborator

icculus commented Dec 25, 2024

The \since should be updated, as the enum wasn't in the public api before this.

But I'm not sure what the right version is, since we might do a release candidate before 3.2.0. Let's fix that after merging the PR.

@slouken
Copy link
Collaborator

slouken commented Dec 25, 2024

The version should be 3.1.8

@slouken
Copy link
Collaborator

slouken commented Dec 25, 2024

I'll go ahead and merge, and we can fix it up afterwards. Thanks!

@slouken slouken merged commit ca4f5dd into libsdl-org:main Dec 25, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants