Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMAKE_CURRENT_*_DIR instead of CMAKE_*_DIR #391

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

humbertodias
Copy link
Contributor

@humbertodias humbertodias commented Oct 5, 2023

This PR allows for building with cmake's add_subdirectory function, like so:

Build and include SDL in main project

add_subdirectory(lib/SDL2_image lib/SDL2_image_BIN EXCLUDE_FROM_ALL)
target_link_libraries(main PRIVATE SDL2_image)

@madebr madebr merged commit c4cd804 into libsdl-org:main Oct 5, 2023
5 checks passed
@sezero
Copy link
Contributor

sezero commented Oct 5, 2023

(i) Same goes for the SDL2 branch

(ii) Same goes for both SDL2 nd SDL3 branches of all other SDL satellite libs

@madebr
Copy link
Contributor

madebr commented Oct 5, 2023

Like the grim reaper, I went around and applied this change to all satellite libraries.
SDL itself already did this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants