Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL2] fixes to autotools find_lib usage for mac (and windows) #395

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

sezero
Copy link
Contributor

@sezero sezero commented Oct 22, 2023

Before this, configure used to find dylibs like this:

-- dynamic libwebp -> libwebp.dylib
-- dynamic libwebpdemux -> libwebpdemux.dylib
-- dynamic libavif -> libavif.dylib
-- dynamic libjxl -> libjxl.dylib

However, libXXX.dylib are most usually symlinks to their versioned ones
i.e. libXXX.N.dylib, therefore it was the wrong thing to do.

After this, it finds the dylibs like this: (configure script was
deliberately run with --disable-stb-image --disable-imageio in order
to find all possible dylibs) :

-- dynamic libwebp -> libwebp.7.dylib
-- dynamic libwebpdemux -> libwebpdemux.2.dylib
-- dynamic libavif -> libavif.16.dylib
-- dynamic libtiff -> libtiff.5.dylib
-- dynamic libjpeg -> libjpeg.9.dylib
-- dynamic libpng -> libpng16.dylib
-- dynamic libjxl -> libjxl.0.8.dylib

As for windows: Major offender was libavif because of the same versioning
issue -- now fixed.

@slouken, @madebr: Please review, if you can.

P.S.: Actually, SDL2_mixer has the same issue. Maybe I'd apply similar
changes there after this.

@sezero sezero merged commit 8ea5155 into libsdl-org:SDL2 Oct 22, 2023
8 checks passed
@sezero sezero deleted the find_lib branch October 22, 2023 16:41
@sezero
Copy link
Contributor Author

sezero commented Oct 22, 2023

Merged.

sezero added a commit to sezero/SDL_mixer that referenced this pull request Oct 22, 2023
@sezero
Copy link
Contributor Author

sezero commented Oct 22, 2023

Pushed libsdl-org/SDL_mixer@5885b5e to SDL_mixer SDL2 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants