cmake: add uninstall target

[ChillerDragon]

The code is yoinked from the SDL repo. Works fine on my machine.

chiller@debian:~/Desktop/git/SDL_image/build$ sudo make install
[sudo] password for chiller: 
[ 84%] Built target SDL3_image-shared
[ 92%] Built target showanim
[100%] Built target showimage
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/lib/libSDL3_image.so.0.1.0
-- Up-to-date: /usr/local/lib/libSDL3_image.so.0
-- Set runtime path of "/usr/local/lib/libSDL3_image.so.0.1.0" to ""
-- Up-to-date: /usr/local/lib/libSDL3_image.so
-- Installing: /usr/local/include/SDL3_image/SDL_image.h
-- Installing: /usr/local/lib/cmake/SDL3_image/SDL3_imageConfig.cmake
-- Installing: /usr/local/lib/cmake/SDL3_image/SDL3_imageConfigVersion.cmake
-- Installing: /usr/local/lib/cmake/SDL3_image/SDL3_image-shared-targets.cmake
-- Installing: /usr/local/lib/cmake/SDL3_image/SDL3_image-shared-targets-noconfig.cmake
-- Installing: /usr/local/lib/pkgconfig/sdl3-image.pc
-- Installing: /usr/local/share/licenses/SDL3_image/LICENSE.txt
chiller@debian:~/Desktop/git/SDL_image/build$ sudo make uninstall
-- Uninstalling "/usr/local/lib/libSDL3_image.so.0.1.0"
-- Uninstalling "/usr/local/lib/libSDL3_image.so.0"
-- Uninstalling "/usr/local/lib/libSDL3_image.so"
-- Uninstalling "/usr/local/include/SDL3_image/SDL_image.h"
-- Uninstalling "/usr/local/lib/cmake/SDL3_image/SDL3_imageConfig.cmake"
-- Uninstalling "/usr/local/lib/cmake/SDL3_image/SDL3_imageConfigVersion.cmake"
-- Uninstalling "/usr/local/lib/cmake/SDL3_image/SDL3_image-shared-targets.cmake"
-- Uninstalling "/usr/local/lib/cmake/SDL3_image/SDL3_image-shared-targets-noconfig.cmake"
-- Uninstalling "/usr/local/lib/pkgconfig/sdl3-image.pc"
-- Uninstalling "/usr/local/share/licenses/SDL3_image/LICENSE.txt"
Built target uninstall
chiller@debian:~/Desktop/git/SDL_image/build$ 

[madebr]

Can you please move this block inside the if(SDLIMAGE_INSTALL) block? At around line 1080.
Please also use 4-space indentation.

[ChillerDragon]

done.

I was wondering about that. In SDL there is also a option to disable uninstall. I did not port that. Do we need that here as well? So a if(NOT SDLIMAGE_DISABLE_UNINSTALL) what is that for?

https://github.com/libsdl-org/SDL/blob/e027b85cc457556071cbb2f3f1bcf8803c1bc001/CMakeLists.txt#L262

[ChillerDragon]

Apparently to support sub projects better according to libsdl-org/SDL@bb9ebad

But I do not think that case needs a separation between install and uninstall. Should be fine to make the uninstall dependent on the install option.

[ChillerDragon]

Is the failling CI on me?

[madebr]

Is the failling CI on me?

We have a known test issue with newer libjxl.

[slouken]

@madebr, does this make sense to add to the other satellite libraries?

[madebr]

@madebr, does this make sense to add to the other satellite libraries?

For those crazy enough to install directly to their root prefix, it's useful.
But I would not promote this kind of behavior.

[slouken]

We should either remove this PR or apply it universally.

My usual workflow is:
mkdir build
cd build
cmake ..
make install

I have often wanted to be able to
make uninstall

Does this PR make that possible?

[madebr]

I have often wanted to be able to make uninstall

Does this PR make that possible?

Yes it does

[slouken]

Sweet, then let's propagate it across SDL and satellite libraries.