Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LIBUSB_ENABLE_UDEV option #20

Merged
merged 5 commits into from
Dec 25, 2023
Merged

Add LIBUSB_ENABLE_UDEV option #20

merged 5 commits into from
Dec 25, 2023

Conversation

ririyeye
Copy link
Contributor

there is no udev support in some embedded system , they need a option work without libudev
and if we compile sys/socket.h we need to add -D_GNU_SOURCE according to stackoverflow

@mcuee mcuee added the enhancement New feature or request label Dec 21, 2023
@Youw
Copy link
Member

Youw commented Dec 24, 2023

if we compile sys/socket.h we need to add -D_GNU_SOURCE according to stackoverflow

Is it causing a build issue? Which system/compiler?

In any case - lets not introduce two independent changes in one PR.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@Youw
Copy link
Member

Youw commented Dec 24, 2023

nice improvement overall, thanks

no point defning this option for other systems

Co-authored-by: Ihor Dutchak <[email protected]>
@ririyeye
Copy link
Contributor Author

if we compile sys/socket.h we need to add -D_GNU_SOURCE according to stackoverflow

Is it causing a build issue? Which system/compiler?

In any case - lets not introduce two independent changes in one PR.

in linux-gcc

it may cause build err to linux_netlink.c

i figure out in autoconf , libusb will add _GNU_SOURCE in config.h file , and it add -DHAVE_CONFIG_H flags to include config.h so it works

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Youw Youw merged commit d1fd9d4 into libusb:main Dec 25, 2023
5 checks passed
@Youw
Copy link
Member

Youw commented Dec 25, 2023

i figure out in autoconf , libusb will add _GNU_SOURCE in config.h file , and it add -DHAVE_CONFIG_H flags to include config.h so it works

#21

@ririyeye ririyeye deleted the udev branch December 26, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants