Add sound modes (output select) and extra idle states #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'Sound Output' and changed the default state to Off when state is not playing/paused/stopped.
Added extra idle states
Version 0.6b
Set media content type to music (fixed) so you can see the artist in the Media entity card
Ability to set 'Sound_mode' (speaker select)
New version with for all my changes
New version with for all my changes
List changes compared to original repo.
|
Hi @SirJohnDoe Let me think about how the best way to integrate your changes would be. The CXN streamers don’t have an amplifier, so there’s no output speaker selection to be made there. This functionality is in the CXA component, though. |
|
Ah I see, forgot that this integration was made for CXN. I use speaker select with the Evo 150, but Evo 75 should work too. I guess it shouldn't show up in the non-amp players. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be possible to integrate the 'media_player.py' from my fork to this repository? It's basically the same but with two additions:
I've added sound modes (output select):
And added several idle states, so they're correctly reported in HA. For example, 'no signal' when playing records.
I'm not very experienced with Github, so my commits are a bit of a mess. It'd be better if you just take the code and change it directly in your repo if you choose to integrate it.