Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant publishing stuff in build.sbt #159

Merged
merged 1 commit into from
Nov 3, 2023
Merged

remove redundant publishing stuff in build.sbt #159

merged 1 commit into from
Nov 3, 2023

Conversation

SethTisue
Copy link
Contributor

@SethTisue SethTisue commented Nov 2, 2023 •
edited
Loading

you sometimes see this redundant stuff get cargo culted because it used to be necessary in old sbt versions, but these days publish / skip is sufficient

review by @mdedetrich

mdedetrich
mdedetrich approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip, I took this from Pekko so good to know I can remove it there.

lgtm

@SethTisue SethTisue merged commit 9a850f4 into lightbend-labs:main Nov 3, 2023
7 checks passed
@SethTisue SethTisue deleted the publish-skip branch November 3, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @mdedetrich