remove unnecessary build stuff #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This is again one of those cargo culty things, I would say leave it in there unless the other plugins ( i.e. |
at least, I don't think any of this stuff is recommended or necessary under sbt-ci-release?
SethTisue
force-pushed
the
build-tweak
branch
from
5376578 to
1ed0692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at least, I don't think any of this stuff is recommended or necessary under sbt-ci-release?
@mdedetrich the
pomIncludeRepository, I'm least sure about it. do you know what that's for?note that before this change (but after I added the secrets to the repo) we were seeing successful snapshot publishing at e.g. https://github.com/lightbend-labs/jardiff/actions/runs/6746086611/job/18339309410
so if we merge this, we should double check after that it's still working