Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rename Quickstarts to Samples #542

Merged
merged 1 commit into from
Jan 20, 2024
Merged

docs: rename Quickstarts to Samples #542

merged 1 commit into from
Jan 20, 2024

Conversation

beritou
Copy link
Contributor

@beritou beritou commented Jan 19, 2024

Closes: #540

@github-actions github-actions bot added Documentation Improvements or additions to documentation javascript-sdk kalix-runtime Runtime and SDKs sub-team typescript-sdk labels Jan 19, 2024
@beritou beritou marked this pull request as ready for review January 19, 2024 20:36
@beritou
Copy link
Contributor Author

beritou commented Jan 19, 2024

The failing validate docs job will pass once https://github.com/lightbend/kalix-docs/pull/2030 is merged and deployed to prod.

ennru
ennru approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru
Copy link
Member

ennru commented Jan 20, 2024

The failing validate docs job will pass once https://github.com/lightbend/kalix-docs/pull/2030 is merged and deployed to prod.

Same rename it complains about as in the JVM SDK
[✖] https://docs.kalix.io/samples/index.html → Status: 404

@ennru ennru merged commit 76fd884 into lightbend:main Jan 20, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation javascript-sdk kalix-runtime Runtime and SDKs sub-team typescript-sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Quickstarts to Samples in docs
2 participants
@beritou @ennru