Fix for #783 #784
Open
Fix for #783 #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bserdar
reviewed
May 18, 2017
| @@ -139,7 +139,9 @@ public SetExpressionEvaluator(JsonNodeFactory factory, FieldTreeNode context, Se | |||
| } else if (mdNode instanceof ArrayField) { | |||
| data = initializeArray(rvalue, refMdNode, mdNode, field, refPath); | |||
| } | |||
| setValues.add(data); | |||
| if (data != null) { | |||
There was a problem hiding this comment.
this would work, but we should also add an if statement before instanceof ArrayField (becayse ResolvedReferenceField extends ArrayField)
if(mdNode instanceof ResolvedReferenceField) {
// then, if the set-to value is null, set data to null, so it won't be added to setValues. If it is non-null, throw error, because the call is setting a reference to a non-null value.
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hint on what the problem with #783 might be. Didn't test it.