-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docstrings #1216
Comments
@guarin Is this issue resolved? If not then please assign it to me. I would love to work on this. |
Hi and thanks for working on this! Could you quickly indicate on which files you would work? |
lightly/models/utils.py |
Awesome, created the issue for you: #1663 If you comment on it I can assign it to you. |
Please create a issue for Cleanup docstrings in lightly/embedding subpackage and assign it to me. @guarin |
Created the issue, if you comment on it I'll be able to assign it to you |
@guarin I want to work on lightly/loss subpackage, lightly/data subpackage, and lightly/utils subpackage. Please assign it to me. |
@ayush22iitbhu I created the issue, I can assign it to you if you comment on it. #1673 I'll keep the others unassigned for now. |
@guarin I want to work on lightly/models/modules subpackage. Can you assign it to me. |
Awesome, can you comment on the issue #1687 then I can assign it to you |
Description
Go through all PIP modules and make sure that the docstrings are consistently formatted and complete.
This is an example of a well documented file: https://github.com/lightly-ai/lightly/blob/master/lightly/models/modules/memory_bank.py
When updating docstrings or comments keep the following in mind:
def fun(value: int = 5)
there is no need to document that5
is the default forvalue
in the docstring. It is already visible in the function definition. However, if the function is defined asdef fun(value: int | None = None)
and in the code we do:if value is None: value = 5
we should document that value is set to5
by default as this is not evident from the function definition.How to work on this issue
Tasks
The text was updated successfully, but these errors were encountered: