-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup docstrings in lightly/utils subpackage #1698
Cleanup docstrings in lightly/utils subpackage #1698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
Two geral comments:
- Please focus on updating docstrings or error strings. Logic changes, if any, should be done in separate PRs. It also makes this easier to approved and get merged :)
- Before any commit, format the code using the auto formatter. See the contribution docs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
+ Coverage 84.85% 84.86% +0.01%
==========================================
Files 155 155
Lines 6509 6508 -1
==========================================
Hits 5523 5523
+ Misses 986 985 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for updating the PR @HarshitVashisht11 !
Only a few last points, then this is ready to merge :)
Also don't to forget to run make format
before any commits.
…ocstring-update
…11/lightly into docstring-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your update!
Your formatter seems to have a different version than the required one, I fixed it and pushed.
Let's get this merged :)
fixes #1675