Adding type check for serve.py

[ishaanagw]

No description provided.

[ishaanagw]

Hey @philippmwirth, please review this MR. Thanks.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (34aa499) to head (ad37b03).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
lightly/api/serve.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1652   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files         151      151           
  Lines        6446     6447    +1     
=======================================
+ Hits         5460     5461    +1     
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SauravMaheshkar]

LGTM ❤️

[SauravMaheshkar]

Partly fixes #1635

[ishaanagw]

Hey, thanks, very new to this open source, can you also merge it ? or do you guys follow some release timelines ?

[SauravMaheshkar]

Hey, thanks, very new to this open source, can you also merge it ? or do you guys follow some release timelines ?

Hello 👋🏽 , I think in order for this PR to count for your Hacktoberfest total we'd have to merge it between Oct 1-31. I'm going to wait on @guarin for this.

[ishaanagw]

Ohh, but I am not doing it for hacktober fest, so if you can merge it then please go ahead, Thanks.

[guarin]

Thanks a lot for the PR! There is one small thing that needs changing before we can merge it, sorry for the annoyance. I'll update the issue description to reflect that we need older type hints.

[guarin]

@ishaanagw do you need help with the PR? I can also update to get it merged :)

[guarin]

Awesome, thanks!