rustfmt: Run on util/* (2/2)
#3323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3323 +/- ##
==========================================
- Coverage 89.62% 89.56% -0.07%
==========================================
Files 127 127
Lines 103517 104124 +607
Branches 103517 104124 +607
==========================================
+ Hits 92780 93257 +477
- Misses 8041 8116 +75
- Partials 2696 2751 +55 ☔ View full report in Codecov by Sentry. |
tnull
commented
Sep 18, 2024
tnull
force-pushed
the
2024-09-rustfmt-util
branch
2 times, most recently
from
6c4dd83
to
9b991df
Compare
|
Ugh, can we split this? 42 commits in one PR is just a lot... |
Alright, happy to if you prefer (although at least half of these commits are one-line diffs). Now split out ~the first half of commits to #3324. |
tnull
force-pushed
the
2024-09-rustfmt-util
branch
2 times, most recently
from
60ae0af
to
e2dcdc7
Compare
|
Rebased after #3327 landed. |
tnull
force-pushed
the
2024-09-rustfmt-util
branch
from
e2dcdc7
to
bc122e3
Compare
|
Rebased after #3324 landed. |
.. we pull out `Mutex` field initialization into dedicated variables as they might otherwise land on the same line when formatting, which might lead to lockorder violation false-positives when compiled with the `backtrace` feature.
tnull
force-pushed
the
2024-09-rustfmt-util
branch
from
bc122e3
to
572f48c
Compare
|
Rebased to resolve minor conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 2/2, based on #3324.
The diff is a bit larger for this one, but AFAICT the changes look mostly reasonable (besides the oddity commented below).
FWIW, I had a look at currently open inflight PRs and the conflicts should be minimal if I'm not overlooking something.