Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pricesrpc: fix build tag formatting #140

Merged
merged 1 commit into from
Jul 8, 2024
Merged

pricesrpc: fix build tag formatting #140

merged 1 commit into from
Jul 8, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Jul 8, 2024

Fixes #139 (comment), didn't realize that no change to falafel itself was needed...

@guggero guggero requested a review from starius July 8, 2024 07:13
starius
starius approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@starius starius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I tested make fmt locally. It does not produce any diff.
The test failure in CI seem to be flaky.

@guggero guggero merged commit f2f4ed2 into lightninglabs:master Jul 8, 2024
5 checks passed
@guggero guggero deleted the falafel-format branch July 8, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starius starius starius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guggero @starius