Asset Minting with V1 Asset Group Key and Chantools Cold Storage Support #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new field to the ListBatches RPC endpoint response. This field contains the byte-serialized PSBT equivalent of the group virtual transaction field for unsealed assets.
Introduce a general return type, `FundBatchResp`, for the `FundBatch` method. This allows for easier extension with additional fields in the future, enabling the FundBatch state machine to return extra fields as needed.
Add a function to create a verbose mint batch from a regular mint batch. This function is extracted by refactoring existing code from the list batch functionality.
The FundBatch RPC endpoint now returns a verbose batch instead of a regular batch. The verbose batch includes additional asset group information required by external signers.
If an external key is specified during minting, generate a V1 asset group key which uses the new group key formulation. This commit lays down the ground work with placeholder arguments which will be used (populated) correctly in a later commit.
TODO: in this commit, GroupKeyRequest contains both TapscriptRoot and CustomTapscriptRoot, remove one of these?
Add a test harness to execute the chantools binary via the command line and parse its output.
Adds a test to ensure the new PSBT field introduced in the previous commit can be used to derive a transaction identical to the group virtual transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on Oli's WIP to demonstrate asset minting using the new V1 asset group key formulation. It integrates
chantoolsto mint assets with an external asset group signing key (taproot internal key), offering a viable option for users who wish to keep their asset group signing key in cold storage.A new integration test is included to simulate user behavior by leveraging
chantoolsvia the command line. The test verifies that the minter can successfully sign an asset into the asset group using the external asset group signing key.