Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: rename RPC AssetLeaf proof field to account for transfer proofs #640

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 1, 2023

The field is now used to hold transfer proofs. This PR corrects the field name to account for that fact.

This PR needs to be merged first: #637
(To avoid rebase delay.)

@ffranr ffranr self-assigned this Nov 1, 2023
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📘

@ffranr ffranr marked this pull request as draft November 2, 2023 00:35
@jharveyb
Copy link
Contributor

jharveyb commented Nov 2, 2023

Draft to block merging or planning to add more?

@ffranr ffranr force-pushed the rename-asset-leaf-issuance-proof branch from 46b053d to 3769da2 Compare November 2, 2023 20:42
@ffranr ffranr marked this pull request as ready for review November 2, 2023 20:42
@ffranr
Copy link
Contributor Author

ffranr commented Nov 2, 2023

@jharveyb It was in draft to block merging. But ready for review + merge now!

@ffranr ffranr force-pushed the rename-asset-leaf-issuance-proof branch from 3769da2 to 088fb32 Compare November 2, 2023 21:03
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ffranr ffranr marked this pull request as draft November 2, 2023 21:56
@ffranr ffranr marked this pull request as ready for review November 2, 2023 22:02
@ffranr ffranr added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit e3cf11e Nov 2, 2023
14 checks passed
@jharveyb jharveyb deleted the rename-asset-leaf-issuance-proof branch November 16, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants