Merge pull request #21 from lightstep/RBAC

Changed default to run under LS serviceAccount
lightstep · Apr 17, 2021 · 6ab72cc · 6ab72cc
2 parents 1e31f26 + 8d5251a
commit 6ab72cc
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/charts/lightstepsatellite/CHANGELOG.md b/charts/lightstepsatellite/CHANGELOG.md
@@ -1,8 +1,16 @@
+##1.2.4
+
+ENHANCEMENTS:
+
+* Changed the default serviceaccpimt to be the Lightstep provisioned serviceaccount. This should enable easier 'default' deployments
+
+
 ##1.2.3
 
 ENHANCEMENTS:
 
 * Added a service for statsD-exporter
+* Changed default service type to LoadBalancer in order to provide a publicly accessible endpoint
 * Updated REAME with accurate metrics functionality
 * Added another maintainer
 

diff --git a/charts/lightstepsatellite/Chart.yaml b/charts/lightstepsatellite/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v1
 name: lightstep
-version: 1.2.3
+version: 1.2.4
 appVersion: "2021-01-26_23-02-36Z"
 description: Lightstep satellite to collect telemetry data.
 home: https://lightstep.com/

diff --git a/charts/lightstepsatellite/values.yaml b/charts/lightstepsatellite/values.yaml
@@ -17,30 +17,30 @@ fullnameOverride: ""
 
 serviceAccount:
   # Specifies whether a service account should be created
-  create: false
+  create: true
   # Annotations to add to the service account
   annotations: {}
   # -- the name of the service account to use; if not set and create is true, a name is generated using the fullname template
   name:
   role:
     # Specifies whether get/watch/list for pods role should be created
-    create: false
+    create: true
     name: lightstep-pod-reader
   clusterRole:
     # Specifies whether get/watch/list for nodes clusterRole should be created
-    create: false
+    create: true
     name: lightstep-node-reader
   roleBinding:
     # Specifies whether role should be created
-    create: false
+    create: true
     name: lightstep-read-pods
     # -- if not set and create is true, the `serviceAccount.role.name` is used
     roleRefName:
     # -- if not set and and create is true, the generated serviceAccount name is used
     serviceAccountName:
   clusterRoleBinding:
     # Specifies whether clusterRole should be created
-    create: false
+    create: true
     name: lightstep-read-nodes
     # -- if not set and create is true, the `serviceAccount.clusterRole.name` is used
     roleRefName:
@@ -74,7 +74,7 @@ service:
   grpcinsecure: 8184
   annotations: {}
   # -- set to true to create a service for the statsd exporter. This endpoint will yield a Prometheus endpoint to scrape
-  metricExporter: false
+  metricExporter: true
   metricServiceType: LoadBalancer
   # -- This should be the same as the podAnnotations.prometheus.io/port value
   promScrapeEndpoint: 9102