Locked tokens fix #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running test 04_claim_tokens_overflow.js shows that a hatcher is unable to claim their tokens. This function CommonsToken.claimTokens() calculates that the hatcher can claim more tokens that they have been allocated. This is because during CommonsToken.burn() the variable CommonsToken.unlockedInternal has increased to greater than CommonsToken.initialRaise()
- Logic added to protect against unlockedInternal being larger than the total locked tokens. - Logic added to unsure that a hatcher can never have more unlocked tokens than they have currently locked.
Correct calculation of p0 during allocation, burning and claiming tokens,
|
A fix for: commons-stack#18 |
EnchanterIO
suggested changes
Jan 9, 2020
There was a problem hiding this comment.
The comment on line 17 padExternal / p0 https://github.com/lightstreams-network/genesis-contracts/pull/5/files#diff-a47469acf810b124d04e7d1a3ea5b4feL17 should change to paidExternal * p0
The 02_artist_token_flow test is failing if you change p0 to 2 because of a test line: (AMOUNT_TO_RAISE_PHT / P0 ) should be also (AMOUNT_TO_RAISE_PHT * P0 )
I will commit the changes
EnchanterIO
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following two bugs.
BUG 1: Running test 04_claim_tokens_overflow.js shows that a hatcher is unable to claim their tokens.
The function CommonsToken.claimTokens() calculates that the hatcher can claim more tokens that they have been allocated. This is because during CommonsToken.burn() the variable CommonsToken.unlockedInternal has increased to greater than CommonsToken.initialRaise().
BUG 2: Running test 04_claim_tokens_overflow.js shows that the incorrect amount of tokens are unlocked.
This is because the calculation for unlocking tokens using p0 is incorrect.