[TAS-2441] ✨ Implement collector memo section #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraHuang22
added a commit
that referenced
this pull request
Dec 24, 2024
nwingt
reviewed
Dec 27, 2024
| v-if="authorReplied" | ||
| :class="[ | ||
| 'absolute bottom-0 right-[6px]', | ||
| authorReplied ? 'group-hover:right-[22px]' : '', |
There was a problem hiding this comment.
Suggested change
| authorReplied ? 'group-hover:right-[22px]' : '', | |
| { 'group-hover:right-[22px]': authorReplied }, |
There was a problem hiding this comment.
| ]" | ||
| :style="bgStyle" | ||
| > | ||
| <p class="block text-[16px] line-clamp-4">{{ buyerMessage }}</p> |
There was a problem hiding this comment.
Suggested change
| <p class="block text-[16px] line-clamp-4">{{ buyerMessage }}</p> | |
| <p class="block text-[16px] line-clamp-4" v-text="buyerMessage" /> |
There was a problem hiding this comment.
| buyerMessage() { | ||
| return this.message?.buyerMessage; | ||
| }, | ||
| authorReplied() { |
There was a problem hiding this comment.
Suggested change
| authorReplied() { | |
| hasAuthorReplied() { |
There was a problem hiding this comment.
Comment on lines
529
to
530
| isHistoryInfoLoading: false, | ||
| isFinishedLoadingHistory: false, |
There was a problem hiding this comment.
Suggested change
| isHistoryInfoLoading: false, | |
| isFinishedLoadingHistory: false, | |
| isHistoryInfoLoading: false, | |
| hasHistoryInfoLoaded: false, |
There was a problem hiding this comment.
src/util/ui.js
Outdated
Comment on lines
25
to
37
| export function ellipsisCollectorAddress(value) { | ||
| if (value) { | ||
| const len = value.length; | ||
| const dots = '...'; | ||
| if (!value) return ''; | ||
| if (value.length > 10) { | ||
| return value.substring(0, 8) + dots; | ||
| } | ||
| return value; | ||
| } | ||
| return value; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can reuse this instead?
Lines 12 to 23 in 447460d
There was a problem hiding this comment.
|
the resolution of avatar images are too low in retina display, please use 2x or even 3x of the current size |
nwingt
reviewed
Dec 27, 2024
src/components/ScrollingList.vue
Outdated
Comment on lines
49
to
51
| durationTime() { | ||
| return this.animationDuration; | ||
| }, |
There was a problem hiding this comment.
src/components/ScrollingList.vue
Outdated
Comment on lines
77
to
84
| .animate-scroll { | ||
| animation: scroll var(--animation-duration, 60s) infinite linear; | ||
| } | ||
|
|
||
| .animate-scroll.delay { | ||
| animation: scroll var(--animation-duration, 60s) infinite linear; | ||
| animation-delay: calc(var(--animation-duration, 60s) * -1); | ||
| } |
There was a problem hiding this comment.
Suggested change
| .animate-scroll { | |
| animation: scroll var(--animation-duration, 60s) infinite linear; | |
| } | |
| .animate-scroll.delay { | |
| animation: scroll var(--animation-duration, 60s) infinite linear; | |
| animation-delay: calc(var(--animation-duration, 60s) * -1); | |
| } | |
| .animate-scroll, | |
| .animate-scroll.delay { | |
| animation: scroll var(--animation-duration, 60s) infinite linear; | |
| } | |
| .animate-scroll.delay { | |
| animation-delay: calc(var(--animation-duration, 60s) * -1); | |
| } |
There was a problem hiding this comment.
src/components/ScrollingList.vue
Outdated
| props: { | ||
| animationDuration: { | ||
| type: String, | ||
| default: '60s', |
There was a problem hiding this comment.
Should we add unit here or just number?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default.mp4