[TAS-2785] ✨ Add random keyword search feature to homepage #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraHuang22
added a commit
that referenced
this pull request
Dec 26, 2024
nwingt
reviewed
Dec 27, 2024
src/pages/index.vue
Outdated
Comment on lines
850
to
851
| placeholderText: '', | ||
| randomKeywords: [], |
There was a problem hiding this comment.
src/pages/index.vue
Outdated
Comment on lines
1114
to
1124
| getRandomPlaceholder() { | ||
| if (this.$i18n.locale === 'zh-Hant') { | ||
| const shuffled = [...SEARCH_SUGGESTIONS].sort( | ||
| () => Math.random() - 0.5 | ||
| ); | ||
| const randomTerms = shuffled.slice(0, 3); | ||
| this.randomKeywords = randomTerms; | ||
| return randomTerms.join('、'); | ||
| } | ||
| return this.$t('gutenberg_search_placeholder'); | ||
| }, |
There was a problem hiding this comment.
Can be refactored to a searchMixin?
There was a problem hiding this comment.
Since the two use cases(homepage/ bookstore) are different, refactor it as a mixin would require more modifications. so I think it doesn't need to be made into a mixin.
nwingt
reviewed
Dec 27, 2024
src/pages/index.vue
Outdated
Comment on lines
1020
to
1022
| this.placeholderText = this.randomKeywords?.length | ||
| ? this.randomKeywords.join('、') | ||
| : this.$t('gutenberg_search_placeholder'); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.