[TAS-2787] 📈 Add logging for PDF download event #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuroraHuang22
changed the title
williamchong
requested changes
Dec 31, 2024
src/pages/reader/pdf.vue
Outdated
| }, | ||
| 1 | ||
| ); | ||
| console.log(`PDF downloaded: ${event.data.filename}`); |
There was a problem hiding this comment.
Please remove unneeded console.log
src/pages/reader/pdf.vue
Outdated
Comment on lines
87
to
96
| logTrackerEvent( | ||
| this, | ||
| 'ReaderPdf', | ||
| 'PDFDownloaded', | ||
| { | ||
| classId: this.classId, | ||
| filename: event.data.filename, | ||
| }, | ||
| 1 | ||
| ); |
There was a problem hiding this comment.
4th param does not expect object
and maybe we should name it as present tense since download is not completed at this point
Suggested change
| logTrackerEvent( | |
| this, | |
| 'ReaderPdf', | |
| 'PDFDownloaded', | |
| { | |
| classId: this.classId, | |
| filename: event.data.filename, | |
| }, | |
| 1 | |
| ); | |
| logTrackerEvent( | |
| this, | |
| 'ReaderPdf', | |
| 'ReaderDownloadPdf', | |
| classId: this.classId, | |
| 1 | |
| ); |
williamchong
requested changes
Jan 2, 2025
src/pages/reader/pdf.vue
Outdated
Comment on lines
85
to
86
| } | ||
| if (event.data.event === 'pdfDownload') { |
There was a problem hiding this comment.
Suggested change
| } | |
| if (event.data.event === 'pdfDownload') { | |
| } else if (event.data.event === 'pdfDownload') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listen event from likecoin/pdf.js#10