Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android-sdk improvements #214

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Apr 2, 2022

  • Returns all matched versions to support list options
  • Don't hard-code the host OS
  • Document the default of channel

I'm lazy so I put different changes in a single commit. Please tell me if you want separate commits :D

* Returns all matched versions to support list options
* Don't hard-code the host OS
* Document the default of `channel`
@yan12125
Copy link
Contributor Author

yan12125 commented Apr 2, 2022

Oh, after a long unmaintained period, httpbin is now completely broken... postmanlabs/httpbin#673

I will try pin an older werkzeug like others do as a temporary workaround.

@lilydjwg
Copy link
Owner

lilydjwg commented Apr 2, 2022

Oops, latest werkzeug breaks quite a lot of things. I'll wait for your fix to the tests.

@lilydjwg lilydjwg merged commit 1235d77 into lilydjwg:master Apr 2, 2022
@yan12125
Copy link
Contributor Author

yan12125 commented Apr 2, 2022

Oh, you're as fast as thunder :) I'm still looking at mypy errors.

@yan12125 yan12125 deleted the android-sdk-improvements branch April 2, 2022 04:11
@lilydjwg
Copy link
Owner

lilydjwg commented Apr 2, 2022

I have caught up with lilac, yay!

@yan12125
Copy link
Contributor Author

Oh, after a long unmaintained period, httpbin is now completely broken...

Hit by this again today when I tried to upgrade community/nvchecker package in Arch Linux. I proposed to backport the fix in Arch https://bugs.archlinux.org/task/74443. Let's see how Felix thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants