-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue15 test simplesorting end user1 #20
Closed
shirasassoon
wants to merge
76
commits into
lilypolonetsky:master
from
JMCanning78:issue15-test-simplesorting-end-user1
Closed
Issue15 test simplesorting end user1 #20
shirasassoon
wants to merge
76
commits into
lilypolonetsky:master
from
JMCanning78:issue15-test-simplesorting-end-user1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved all initialization into app construtor. Changed initial load to be 8 random numbers but used fixed seed from command line launch for later regression tests.
Strangely, importing packages in the same directory didn't work when importing the entire PythonVisualizations library. I had to import them with a leading period to show they were relative. That broke loading them when importing while the current directory is PythonVisualizations. The result is, the code tries to load them one way and fails over to the other method if it can't find them.
…lization All animations now use moveItems to perform a linear movement of canvas items. The insert operation animates the arrival of the new value in the array cell.
… goal Moved more animation routines into VisualizationApp and made use of them for Array.
The AlgorithmVisualizations.py application now discovers and displays a partially working Simple Sorting visualization.
The AlgorithmVisualizations.py application now discovers and displays a partially working Simple Sorting visualization.
Also fixed a bug with the find operation in SimpleSorting.py
Highlighting only set up for InsertionSort. Changed representation of cleanup to be a set for easier removal of items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #15 SimpleSorting.py end-user tests