Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Connect was synchronous #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX] Connect was synchronous #70

wants to merge 1 commit into from
+16 −14

Conversation

chibenwa
Copy link
Member

  • Blocking threads in Akka actor system is a baaad practice
  • False measurement of connect timings as "connect" was a noop

@chibenwa chibenwa self-assigned this Apr 12, 2023
@chibenwa
[FIX] Connect was not properly measured
0ea4743 
 - False measurement of connect timings as "connect" was a noop
@chibenwa
Copy link
Member Author

Build 🍏 locally

@Arsnael
Copy link
Member

Arsnael commented Apr 13, 2023

Need to investigate on the CI as the issue on master is the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arsnael Arsnael Arsnael approved these changes

Assignees

@chibenwa chibenwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chibenwa @Arsnael