#2 Cherry pick add style/attachment/inline image button to app bar composer on mobile (#2532, #2584)
#2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dab246
changed the title
attachment image button to app bar composer (#2532)attachment/image button to app bar composer (#2532)
dab246
changed the title
attachment/image button to app bar composer (#2532)attachment/image button to app bar composer (#2532)
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/2794. |
3 tasks
dab246
changed the title
attachment/image button to app bar composer (#2532)style/attachment/inline image button to app bar composer on mobile (#2532)
tddang-linagora
approved these changes
Apr 22, 2024
dab246
changed the title
style/attachment/inline image button to app bar composer on mobile (#2532)style/attachment/inline image button to app bar composer on mobile (#2532, #2584)
dab246
force-pushed
the
cherry-pick-tf-2532-add-attachment-image-to-app-bar-composer
branch
from
9865b0c
to
e6eff37
Compare
|
Rebase to the |
|
Root cause
@hoangdat Please fetch latest PR then test again DemoScreen_recording_20240620_162644.webm |
|
|
linagora/enough_html_editor#30 was merged. Please update pubspec. @dab246 |
… file Signed-off-by: dab246 <[email protected]> (cherry picked from commit 181e1ec)
… of composer in mobile
dab246
force-pushed
the
cherry-pick-tf-2532-add-attachment-image-to-app-bar-composer
branch
from
e6eff37
to
0a1d3de
Compare
Updated. Please fetch latest commit and test again. Thanks |
hoangdat
reviewed
Jun 22, 2024
Comment on lines
-173
to
-175
| final uploadFileState = _uploadingStateInlineFiles.getUploadFileStateById(success.uploadId); | ||
| log('UploadController::_handleProgressUploadInlineImageStateStream:uploadId: ${uploadFileState?.uploadTaskId} | fromFileShared: ${uploadFileState?.file?.isShared}'); | ||
|
|
There was a problem hiding this comment.
final uploadFileState is just for logging purposes, we don't need it. Avoid wasting memory
|
tddang-linagora
approved these changes
Jun 24, 2024
hoangdat
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2532
#2584
Dependent
bugfix/add-request-focus-node-in-html(PR #27) enough_html_editor#30Demo
mobile-app.webm
demo.mp4
demo2.mov
web-appp.online-video-cutter.com.mp4