#3 Cherry pick fix rich text not work on android (#2475) #2795

dab246 · 2024-04-11T08:40:34Z

Issue

#2475

Dependent

Need merged:
- Cherry pick bugfix/rich-text-composer-not-work (PR #25) rich-text-composer#28
- Cherry pick bugfix/upgrade-version-inappwebview (PR #27) html-editor-enhanced#36

Demo

demo.webm

github-actions · 2024-04-11T08:50:38Z

This PR has been deployed to https://linagora.github.io/tmail-flutter/2795.

lib/features/manage_account/presentation/vacation/vacation_controller.dart

dab246 · 2024-06-13T09:28:06Z

Rebase to the refactor branch is complete

…flutter_typeahead` version `0.5.2` Signed-off-by: dab246 <[email protected]> (cherry picked from commit 87d1a17)

…html

hoangdat · 2024-06-25T07:41:10Z

still have the problem of focus when we change focus from recipient fields to body editor
when we change focus to body editor, we still see that keyboard up and down, especially, sometimes down and never up again. How to prevent keyboard up and down when we move focus from recipient fields to editor?

Screenrecorder-2024-06-25-09-35-55-238.mp4

dab246 · 2024-06-25T07:43:20Z

still have the problem of focus when we change focus from recipient fields to body editor

Screenrecorder-2024-06-25-09-35-55-238.mp4

What is the problem here?

hoangdat · 2024-06-25T07:47:15Z

What is the problem here?

when we change focus to body editor, we still see that keyboard up and down, especially, sometimes down and never up again. How to prevent keyboard up and down when we move focus from recipient fields to editor?

hoangdat · 2024-06-25T08:15:47Z

sometime toolbar is not showed exactly selected option (please check video below from 1:20)

Screenrecorder-2024-06-25-09-49-40-272.mp4

dab246 · 2024-06-25T08:23:38Z

sometime toolbar is not showed exactly selected option (please check video below from 1:20)

Screenrecorder-2024-06-25-09-49-40-272.mp4

Can't see exactly what the error is here. Please rewind the video for a few seconds to see the specific error.

hoangdat · 2024-06-25T08:27:28Z

Can't see exactly what the error is here.

Please play video around 1:13, we also have B, I, U, S in editor, but toolbar only show I, U, S

tddang-linagora · 2024-06-25T13:37:01Z

hoangdat · 2024-06-25T16:24:04Z

Chrome

lib/features/manage_account/presentation/menu/settings/settings_view.dart

dab246 · 2024-06-26T04:58:11Z

still have the problem of focus when we change focus from recipient fields to body editor
when we change focus to body editor, we still see that keyboard up and down, especially, sometimes down and never up again. How to prevent keyboard up and down when we move focus from recipient fields to editor?

Screenrecorder-2024-06-25-09-35-55-238.mp4

Only happens on Android. iOS works fine. On Android, if you persist the soft keyboard, the caret cursor will be duplicated in the WebView and TextField. Therefore, as a workaround, we can only reopen the soft keyboard when moving focus from TextField to WebView

dab246 · 2024-06-26T04:58:33Z

sometime toolbar is not showed exactly selected option (please check video below from 1:20)

Screenrecorder-2024-06-25-09-49-40-272.mp4

Fixed.

tddang-linagora · 2024-06-27T01:37:46Z

hoangdat · 2024-06-27T13:32:41Z

Compromised solution: to prevent double cursor, take the disadvantage of blink blink of keyboard

hoangdat · 2024-06-27T13:38:12Z

Fixed

Still have problem with Bold in my Android

tddang-linagora · 2024-06-28T08:19:02Z

Text format randomly turned off when typing text on start of new line

Ipad air 5th gen - debug mode - preprod env

Screen.Recording.2024-06-28.at.15.15.33.mov

dab246 · 2024-06-29T10:41:22Z

Fixed

Still have problem with Bold in my Android

Root cause

Sometimes WebView auto convert font-weight: bold to font-weight: 700.

Resolved

demo.webm

dab246 · 2024-06-29T10:41:43Z

Text format randomly turned off when typing text on start of new line

Ipad air 5th gen - debug mode - preprod env

Screen.Recording.2024-06-28.at.15.15.33.mov

Reproduce

Select underline style to enable it
Select strikeThrough style to enable it
Enter some text. Now underline & strikeThrough are applied to text
Select again underline style to disable it
Enter some text. Now underline & strikeThrough do not apply to text

=> Turn on both (unlineline and strikeThrough). When you turn off one of them, both will turn off.

Analyze root cause

This error only occurs on safari webkit (iOS, Desktop, Browser). It's related to underline and strikeThrough css style incompatibility on webkit. With safari requires adding -webkit-text-decoration.

Some other mail clients also have similar problems as GMail or Apple Mail

Screen.Recording.2024-06-29.at.16.27.45.mov

RPReplay_Final1719653402.MP4

Currently there is no solution offered to solve this problem.

Conclusion

Android (Mobile/Tablet): Work fine

demo-android.webm

IOS (Mobile/iPad): Not working

dab246 temporarily deployed to PR-2795 April 11, 2024 08:40 — with GitHub Actions Inactive

dab246 requested review from hoangdat and tddang-linagora April 12, 2024 01:46

tddang-linagora reviewed Apr 15, 2024

View reviewed changes

lib/features/manage_account/presentation/vacation/vacation_controller.dart Outdated Show resolved Hide resolved

dab246 temporarily deployed to PR-2795 April 16, 2024 02:54 — with GitHub Actions Inactive

dab246 requested a review from tddang-linagora April 16, 2024 02:54

dab246 mentioned this pull request Apr 16, 2024

[Mobile] Apply correctly the new composer for mobile #2584

Closed

3 tasks

tddang-linagora approved these changes Apr 22, 2024

View reviewed changes

hoangdat added the composer label Jun 10, 2024

This was referenced Jun 11, 2024

Rich text editor doesn't work on android #2922

Closed

[Android][Composer] After input in subject, focus to body, keyboard disappear #2191

Open

dab246 force-pushed the cherry-pick-tf-2475-font-do-not-work-in-mobile branch from 157ad14 to fc188bd Compare June 13, 2024 09:27

dab246 changed the base branch from v0.11.3-patch4-dev-features to refactor June 13, 2024 09:27

dab246 mentioned this pull request Jun 19, 2024

TF-2868 Fix composer bold option toggle #2898

Merged

dab246 force-pushed the cherry-pick-tf-2475-font-do-not-work-in-mobile branch from fc188bd to 85c5b15 Compare June 20, 2024 09:32

dab246 temporarily deployed to PR-2795 June 20, 2024 09:32 — with GitHub Actions Inactive

hoangdat changed the base branch from refactor to combine_cherry_2_cherry_3 June 24, 2024 04:45

dab246 force-pushed the cherry-pick-tf-2475-font-do-not-work-in-mobile branch from 85c5b15 to 6425d33 Compare June 24, 2024 06:13

dab246 had a problem deploying to PR-2795 June 24, 2024 06:13 — with GitHub Actions Failure

dab246 requested a review from tddang-linagora June 24, 2024 06:13

dab246 force-pushed the cherry-pick-tf-2475-font-do-not-work-in-mobile branch from 6425d33 to 15f22be Compare June 24, 2024 10:03

dab246 had a problem deploying to PR-2795 June 24, 2024 10:04 — with GitHub Actions Failure

dab246 force-pushed the cherry-pick-tf-2475-font-do-not-work-in-mobile branch from 15f22be to efa76f2 Compare June 24, 2024 10:05

dab246 temporarily deployed to PR-2795 June 24, 2024 10:11 — with GitHub Actions Inactive

dab246 added 4 commits June 25, 2024 12:15

TF-2475 Upgrade dependencies to build success

1103503

TF-2475 Replace TypeAheadFormField to TypeAheadField compatible `…

2d471b7

…flutter_typeahead` version `0.5.2` Signed-off-by: dab246 <[email protected]> (cherry picked from commit 87d1a17)

TF-2475 Handle format style rich text in composer

dec5185

TF-2475 Handle format style rich text in vacation

e49ca54

TF-2475 Update source script for flutter_inappwebview_web in index.…

09eac41

…html

dab246 force-pushed the cherry-pick-tf-2475-font-do-not-work-in-mobile branch from efa76f2 to fa45406 Compare June 25, 2024 06:48

dab246 temporarily deployed to PR-2795 June 25, 2024 06:48 — with GitHub Actions Inactive

hoangdat reviewed Jun 25, 2024

View reviewed changes

lib/features/manage_account/presentation/menu/settings/settings_view.dart Show resolved Hide resolved

dab246 temporarily deployed to PR-2795 June 26, 2024 02:32 — with GitHub Actions Inactive

hoangdat added the keyboard label Jun 27, 2024

dab246 had a problem deploying to PR-2795 June 29, 2024 10:40 — with GitHub Actions Failure

dab246 requested a review from hoangdat June 29, 2024 10:42

dab246 temporarily deployed to PR-2795 June 29, 2024 10:53 — with GitHub Actions Inactive

TF-2475 Add onSubjectTextListener for subject focus node

bd49100

dab246 force-pushed the cherry-pick-tf-2475-font-do-not-work-in-mobile branch from 7d85402 to bd49100 Compare July 1, 2024 08:00

dab246 had a problem deploying to PR-2795 July 1, 2024 08:00 — with GitHub Actions Failure

dab246 deployed to PR-2795 July 1, 2024 08:08 — with GitHub Actions View deployment

hoangdat merged commit 0ab8b07 into combine_cherry_2_cherry_3 Jul 1, 2024
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#3 Cherry pick fix rich text not work on android (#2475) #2795

#3 Cherry pick fix rich text not work on android (#2475) #2795

dab246 commented Apr 11, 2024

github-actions bot commented Apr 11, 2024

dab246 commented Jun 13, 2024

hoangdat commented Jun 25, 2024 •

edited

Loading

dab246 commented Jun 25, 2024

hoangdat commented Jun 25, 2024

hoangdat commented Jun 25, 2024 •

edited

Loading

dab246 commented Jun 25, 2024

hoangdat commented Jun 25, 2024

tddang-linagora commented Jun 25, 2024 •

edited

Loading

hoangdat commented Jun 25, 2024

dab246 commented Jun 26, 2024

dab246 commented Jun 26, 2024

tddang-linagora commented Jun 27, 2024

hoangdat commented Jun 27, 2024

hoangdat commented Jun 27, 2024

tddang-linagora commented Jun 28, 2024

dab246 commented Jun 29, 2024 •

edited

Loading

dab246 commented Jun 29, 2024

#3 Cherry pick fix rich text not work on android (#2475) #2795

#3 Cherry pick fix rich text not work on android (#2475) #2795

Conversation

dab246 commented Apr 11, 2024

Issue

Dependent

Demo

github-actions bot commented Apr 11, 2024

dab246 commented Jun 13, 2024

hoangdat commented Jun 25, 2024 • edited Loading

dab246 commented Jun 25, 2024

hoangdat commented Jun 25, 2024

hoangdat commented Jun 25, 2024 • edited Loading

dab246 commented Jun 25, 2024

hoangdat commented Jun 25, 2024

tddang-linagora commented Jun 25, 2024 • edited Loading

hoangdat commented Jun 25, 2024

dab246 commented Jun 26, 2024

dab246 commented Jun 26, 2024

tddang-linagora commented Jun 27, 2024

hoangdat commented Jun 27, 2024

hoangdat commented Jun 27, 2024

tddang-linagora commented Jun 28, 2024

dab246 commented Jun 29, 2024 • edited Loading

Root cause

Resolved

dab246 commented Jun 29, 2024

Reproduce

Analyze root cause

Conclusion

hoangdat commented Jun 25, 2024 •

edited

Loading

hoangdat commented Jun 25, 2024 •

edited

Loading

tddang-linagora commented Jun 25, 2024 •

edited

Loading

dab246 commented Jun 29, 2024 •

edited

Loading