Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-2928 Detect loss of connection and reconnect #2999

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Jul 12, 2024

Issue

#2928

Resolved

  • Show confirm dialog when reload page & composer opened:
Screen.Recording.2024-07-12.at.19.08.20.mov
  • Only display toast when get connection error:
Screen.Recording.2024-07-12.at.19.08.57.mov
  • Show confirm dialog when get BadCredentials exception:
Screen.Recording.2024-07-12.at.19.09.26.mov

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2999.

@dab246 dab246 force-pushed the fixbug/tf-2928-detect-loss-of-connection-and-reconnect branch from 5f2ddda to 9101bac Compare July 16, 2024 03:08
@dab246 dab246 force-pushed the fixbug/tf-2928-detect-loss-of-connection-and-reconnect branch from 9101bac to abc8a3f Compare July 16, 2024 07:13
@hoangdat
Copy link
Member

hoangdat commented Jul 16, 2024

  • need to change the name of beforUnload, unload component
  • use flutter dialog (please careful on responsive case)

@dab246
Copy link
Member Author

dab246 commented Jul 17, 2024

  • need to change the name of beforUnload, unload component
  • use flutter dialog (please careful on responsive case)

Fixed.

  • Mobile:

demo-android

  • Web
demo-web.mov

@dab246 dab246 force-pushed the fixbug/tf-2928-detect-loss-of-connection-and-reconnect branch from 728cc10 to 8ec3a53 Compare July 17, 2024 06:50
@hoangdat
Copy link
Member

please rebase

@hoangdat hoangdat merged commit 30c1d80 into sprint_25_flutter_3_22_2 Jul 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants