Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Upgrade to Flutter master branch #3116

Closed
wants to merge 8 commits into from
Closed

[WIP] Upgrade to Flutter master branch #3116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7270b99
Upgrade to Flutter master branch
tddang-linagora Aug 28, 2024
30525ff
Update workflows with Flutter master branch
tddang-linagora Aug 28, 2024
e74e201
Add sample Semantics identifiers
tddang-linagora Aug 29, 2024
2511fcb
Prevent Semantic node missing
tddang-linagora Sep 13, 2024
c40dbf1
Add semantics to from/cc/bcc fields
tddang-linagora Sep 16, 2024
afa8752
Add more semantic entries for composer actions
tddang-linagora Sep 16, 2024
dd7793a
Add semantics for text formatting
tddang-linagora Sep 16, 2024
df855f8
Add Semantics to richtext options
tddang-linagora Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/analyze-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:
- name: Setup flutter
uses: subosito/flutter-action@v2
with:
flutter-version: "3.22.2"
channel: "stable"
flutter-version: "3.25.0-0.1.pre"
channel: "master"
cache: true
cache-key: "deps-${{ hashFiles('**/pubspec.lock') }}"
cache-path: ${{ runner.tool_cache }}/flutter # optional, change this to specify the cache path
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
name: Build dev binaries

env:
FLUTTER_VERSION: 3.22.2
FLUTTER_VERSION: 3.25.0-0.1.pre
XCODE_VERSION: ^15.0.1

jobs:
Expand All @@ -30,7 +30,7 @@ jobs:
uses: subosito/flutter-action@v2
with:
flutter-version: ${{ env.FLUTTER_VERSION }}
channel: "stable"
channel: "master"
cache: true
cache-key: deps-${{ hashFiles('**/pubspec.lock') }} # optional, change this to force refresh cache
cache-path: ${{ runner.tool_cache }}/flutter # optional, change this to specify the cache path
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gh-pages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
- name: Setup flutter
uses: subosito/flutter-action@v2
with:
flutter-version: "3.22.2"
channel: "stable"
flutter-version: "3.25.0-0.1.pre"
channel: "master"
cache: true
cache-key: deps-${{ hashFiles('**/pubspec.lock') }} # optional, change this to force refresh cache
cache-path: ${{ runner.tool_cache }}/flutter # optional, change this to specify the cache path
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
name: Release

env:
FLUTTER_VERSION: 3.22.2
FLUTTER_VERSION: 3.25.0-0.1.pre
XCODE_VERSION: ^15.0.1

jobs:
Expand All @@ -33,7 +33,7 @@ jobs:
uses: subosito/flutter-action@v2
with:
flutter-version: ${{ env.FLUTTER_VERSION }}
channel: "stable"
channel: "master"
cache: true
cache-key: deps-${{ hashFiles('**/pubspec.lock') }} # optional, change this to force refresh cache
cache-path: ${{ runner.tool_cache }}/flutter # optional, change this to specify the cache path
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG FLUTTER_VERSION=3.22.2
ARG FLUTTER_VERSION=3.25.0-0.1.pre
# Stage 1 - Install dependencies and build the app
# This matches the flutter version on our CI/CD pipeline on Github
FROM --platform=amd64 ghcr.io/cirruslabs/flutter:${FLUTTER_VERSION} AS build-env

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / Run integration tests

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

# Set directory to Copy App
WORKDIR /app
Expand All @@ -23,4 +23,4 @@
EXPOSE 80

# Before stating NGinx, re-zip all the content to ensure customizations are propagated
CMD gzip -k -r -f /usr/share/nginx/html/ && nginx -g 'daemon off;'

Check warning on line 26 in Dockerfile

View workflow job for this annotation

GitHub Actions / Run integration tests

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
Loading
Loading