Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-2965 Add retry capability to OIDC check request #3143

Merged
merged 1 commit into from
Sep 17, 2024
Merged

TF-2965 Add retry capability to OIDC check request #3143

merged 1 commit into from
Sep 17, 2024

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Sep 12, 2024 •
edited
Loading

Issue

Demo

  • Status code is 404
Screen.Recording.2024-09-12.at.16.01.01.mov
mobile_404.webm
  • Status code is NOT 404
Screen.Recording.2024-09-12.at.15.57.23.mov
mobile_not_404.webm

@tddang-linagora tddang-linagora self-assigned this Sep 12, 2024
@tddang-linagora tddang-linagora changed the base branch from master to refactor September 12, 2024 09:49
@dab246
Copy link
Member

dab246 commented Sep 13, 2024 •
edited by tddang-linagora
Loading

  • Also verify it on mobile

@tddang-linagora
Copy link
Contributor Author

Also verify it on mobile

Demo updated

@dab246
Copy link
Member

dab246 commented Sep 16, 2024 •
edited by tddang-linagora
Loading

  • Apply new design (Button/Message for each error). Design at here
Screenshot 2024-09-16 at 10 07 30

@hoangdat
Copy link
Member

how did you do for the demo of the case: status code is 404? @tddang-linagora

@tddang-linagora
Copy link
Contributor Author

how did you do for the demo of the case: status code is 404? @tddang-linagora

Throw the expected exception in checkOIDCIsAvailable of oidc_http_client.dart

dab246
dab246 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tddang-linagora
Copy link
Contributor Author

@dab246 @hoangdat Mobile demo updated. Please review latest fixup

@dab246
Copy link
Member

dab246 commented Sep 17, 2024 •
edited by tddang-linagora
Loading

  • Please rebase

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3143.

@hoangdat hoangdat merged commit 0d4c266 into refactor Sep 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 dab246 approved these changes

@chibenwa chibenwa Awaiting requested review from chibenwa

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tddang-linagora @dab246 @hoangdat @chibenwa