Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-2983 Fix download EML with special character #3179

Merged
merged 1 commit into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion model/lib/email/attachment.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class Attachment with EquatableMixin {
'name' : name ?? '',
'type' : type?.mimeType ?? '',
});
return Uri.decodeFull(downloadUri);
return downloadUri;
dab246 marked this conversation as resolved.
Show resolved Hide resolved
}

String generateFileName() {
Expand Down
67 changes: 67 additions & 0 deletions model/test/email/attachment_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:http_parser/http_parser.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
import 'package:jmap_dart_client/jmap/core/id.dart';
import 'package:model/email/attachment.dart';

void main() {
final accountId = AccountId(Id('1'));
const baseDownloadUrl = 'http://localhost/download/{accountId}/{blobId}/{name}?name={name}&type={type}';

group('attachment test:', () {
group('getDownloadUrl:', () {
hoangdat marked this conversation as resolved.
Show resolved Hide resolved
test(
'should return download url with blobId, name and type',
() {
// arrange
final attachment = Attachment(
blobId: Id('some-blob-id'),
name: 'some-name',
type: MediaType.parse('application/octet-stream'),
);

// act
final result = attachment.getDownloadUrl(baseDownloadUrl, accountId);

// assert
expect(result, 'http://localhost/download/1/some-blob-id/some-name?name=some-name&type=application%2Foctet-stream');
});

test(
'should return download url with blobId, name and type '
'when attachment name contains question mark character',
() {
// arrange
final attachment = Attachment(
blobId: Id('some-blob-id'),
name: 'some-name?',
type: MediaType.parse('application/octet-stream'),
);

// act
final result = attachment.getDownloadUrl(baseDownloadUrl, accountId);

// assert
expect(result, 'http://localhost/download/1/some-blob-id/some-name%3F?name=some-name%3F&type=application%2Foctet-stream');
});

test(
'should return download url with blobId, name and type '
'when attachment name is Vietnamese',
() {
// arrange
final attachment = Attachment(
blobId: Id('some-blob-id'),
name: 'tiêu đề attachment',
type: MediaType.parse('application/octet-stream'),
);

// act
final result = attachment.getDownloadUrl(baseDownloadUrl, accountId);

// assert
expect(result, 'http://localhost/download/1/some-blob-id/ti%C3%AAu%20%C4%91%E1%BB%81%20attachment?name=ti%C3%AAu%20%C4%91%E1%BB%81%20attachment&type=application%2Foctet-stream');
});
});
});
}
Loading