[Part 1] Build linux version #1730

Te-Z · 2024-04-25T08:18:54Z

Ticket: #1699

To do:

Improve file download path management for desktop #1767

Fixed:

Capture.video.du.06-05-2024.15.52.00.webm

Te-Z · 2024-04-25T08:23:11Z

Stuck with SSO login for now. I'm trying to update flutter_web_auth_2 (some alpha versions are available) to see if it resolve something but I did not found any solution in its documentation.

Capture.video.du.25-04-2024.10.19.14.webm

hoangdat · 2024-04-25T22:35:15Z

IMO, after app execute OIDC, matrix callback to linux app, but no one can handle it -> block like your video. And I did not found any dependencies support oidc for linux.
we should take a look on: https://github.com/krille-chan/fluffychat, how they handle the issue?

hoangdat · 2024-04-25T23:30:37Z

https://github.com/4D-Technologies/openidconnect_flutter

lib/pages/connect/connect_page_mixin.dart

pubspec.yaml

github-actions · 2024-04-26T13:42:16Z

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1730

sherlockvn · 2024-05-03T07:33:49Z

shortcuts

lib/domain/model/extensions/xfile_extension.dart

lib/pages/chat/chat.dart

lib/pages/image_viewer/image_viewer.dart

lib/pages/settings_dashboard/settings_profile/settings_profile.dart

lib/presentation/mixins/connect_page_mixin.dart

nqhhdev · 2024-05-07T16:11:36Z

lib/pages/chat/chat_input_row.dart

-            )
-            .copyWith(letterSpacing: -0.15),
+  Widget _buildInputBar(BuildContext context) {
+    return Shortcuts(


Does it work on Web platform?

Capture.video.du.14-05-2024.11.40.35.webm

nqhhdev · 2024-05-07T16:12:24Z

lib/pages/chat/chat_input_row_web.dart

@@ -54,39 +52,33 @@ class ChatInputRowWeb extends StatelessWidget {
          Expanded(
            child: inputBar,
          ),
-          KeyBoardShortcuts(


Why remove it?

Because Shortcuts are now in _buildInputBar which is a child widget of ChatInputRowWeb. This allow to use shortcuts whenever the input bar is used. Also this widget did not work. My thought is that it used the wrong focus scope when put inside chat_input_row_web.dart

Here the related lines:

twake-on-matrix/lib/pages/chat/chat_input_row.dart

Lines 74 to 156 in 91419cf

ChatInputRowMobile _buildMobileInputRow(BuildContext context) {

return ChatInputRowMobile(

inputBar: Column(

children: [

ReplyDisplay(controller),

_buildInputBar(context),

],

),

emojiPickerNotifier: controller.showEmojiPickerNotifier,

onEmojiAction: controller.onEmojiAction,

onKeyboardAction: controller.onKeyboardAction,

);

}

ChatInputRowWeb _buildWebInputRow(BuildContext context) {

return ChatInputRowWeb(

inputBar: Column(

children: [

ReplyDisplay(controller),

_buildInputBar(context),

],

),

emojiPickerNotifier: controller.showEmojiPickerNotifier,

onTapMoreBtn: () => controller.onSendFileClick(context),

onEmojiAction: controller.onEmojiAction,

onKeyboardAction: controller.onKeyboardAction,

);

}

Widget _buildInputBar(BuildContext context) {

return Shortcuts(

shortcuts: <LogicalKeySet, Intent>{

LogicalKeySet(

LogicalKeyboardKey.controlLeft,

LogicalKeyboardKey.keyA,

): const SelectAllIntent(),

LogicalKeySet(

LogicalKeyboardKey.altLeft,

LogicalKeyboardKey.keyE,

): const OnEmojiActionIntent(),

},

child: Actions(

actions: <Type, Action<Intent>>{

SelectAllIntent: CallbackAction<SelectAllIntent>(

onInvoke: (_) => controller.selectAll(),

),

OnEmojiActionIntent: CallbackAction<OnEmojiActionIntent>(

onInvoke: (_) => controller.onEmojiAction(),

),

},

child: InputBar(

typeAheadKey: controller.chatComposerTypeAheadKey,

rawKeyboardFocusNode: controller.rawKeyboardListenerFocusNode,

room: controller.room!,

minLines: 1,

maxLines: 8,

autofocus: !PlatformInfos.isMobile,

keyboardType: TextInputType.multiline,

textInputAction: null,

onSubmitted: (_) => controller.onInputBarSubmitted(),

suggestionsController: controller.suggestionsController,

typeAheadFocusNode: controller.inputFocus,

controller: controller.sendController,

focusSuggestionController: controller.focusSuggestionController,

suggestionScrollController: controller.suggestionScrollController,

showEmojiPickerNotifier: controller.showEmojiPickerNotifier,

decoration: InputDecoration(

hintText: L10n.of(context)!.chatMessage,

hintMaxLines: 1,

hintStyle: Theme.of(context)

.textTheme

.bodyLarge

?.merge(

Theme.of(context).inputDecorationTheme.hintStyle,

)

.copyWith(letterSpacing: -0.15),

),

onChanged: controller.onInputBarChanged,

),

),

);

}

}

lib/presentation/mixins/connect_page_mixin.dart

nqhhdev · 2024-05-07T16:16:33Z

lib/presentation/mixins/send_files_mixin.dart

+    final String initialDirectory =
+        (await getApplicationDocumentsDirectory()).path;
+    final List<XFile> xFiles =
+        await openFiles(initialDirectory: initialDirectory);


IMO: I saw you still using it in another place (lib/pages/settings_dashboard/settings_profile/settings_profile.dart). Can you separate this func so it can be reused?

IMO:

If (await getApplicationDocumentsDirectory()).path or await openFiles(initialDirectory: initialDirectory)
has error, how to handle error?

Should try catch for this case, WDYT?

IMO: I saw you still using it in another place (lib/pages/settings_dashboard/settings_profile/settings_profile.dart). Can you separate this func so it can be reused?

Actually on lib/pages/settings_dashboard/settings_profile/settings_profile.dart the method used is openFile without the s at the end of the word file. This method force user to open only one file.

But openFiles used here allow user to select multiple files

IMO:

If (await getApplicationDocumentsDirectory()).path or await openFiles(initialDirectory: initialDirectory)
has error, how to handle error?

Should try catch for this case, WDYT?

done

lib/utils/manager/storage_directory_manager.dart

sherlockvn · 2024-05-08T07:17:01Z

lib/utils/manager/storage_directory_manager.dart

+    final fileStoreDirectory = await StorageDirectoryManager.instance
+        .getFileStoreDirectory(isTemporary: isTemporary);
+    if (isTemporary) {
+      return '$fileStoreDirectory/$eventId/decrypted-$fileName';
+    }
+    return '$fileStoreDirectory/${AppConfig.applicationName}/decrypted-$fileName';


just make another method

Still confused

See #1730 (comment)

lib/widgets/mixins/handle_download_and_preview_file_mixin.dart

lib/pages/connect/connect_page_mixin.dart

lib/presentation/mixins/connect_page_mixin.dart

lib/domain/model/extensions/xfile_extension.dart

lib/pages/bootstrap/bootstrap_dialog.dart

lib/pages/chat/chat.dart

pubspec.yaml

hoangdat · 2024-05-11T02:51:11Z

Hi @Te-Z ,
I still have some remarks:

test responsive: mobile-web
chat event list: why need to separate mobile/web, responsive thi sao // build in all platform, demo to avoid side effect
chat input: build in all platform, demo to avoid side effect
message_content: native: mobile/desktop should base on stream, web still base on bytes
chat details media page
chat list header
chat search view: because related to download content: view can reuse from web (but take care responsive) but logic should base on stream
file picker in all platforms
redirect in OIDC, port?, what happen if this port is used by other service?
play video is laggy
cache location in desktop

…ation

Te-Z · 2024-05-15T14:01:45Z

Hi @Te-Z , I still have some remarks:

test responsive: mobile-web

chat event list: why need to separate mobile/web, responsive thi sao // build in all platform, demo to avoid side effect

chat input: build in all platform, demo to avoid side effect

message_content: native: mobile/desktop should base on stream, web still base on bytes

chat details media page

chat list header

chat search view: because related to download content: view can reuse from web (but take care responsive) but logic should base on stream

file picker in all platforms

redirect in OIDC, port?, what happen if this port is used by other service?

play video is laggy

cache location in desktop

Hi @hoangdat

about chat event list: I did not, it was already separated but it was done to use the SelectionArea widget on web and desktop. Here's a demo for this point and the responsive test:
- desktop (side by side with current beta version)

Capture.video.du.15-05-2024.15.16.44.webm

web

Capture.video.du.15-05-2024.15.30.44.webm

mobile

Capture.video.du.15-05-2024.15.37.04.webm

chat input row:
- desktop

Capture.video.du.15-05-2024.15.54.24.webm

web
- [Part 1] Build linux version #1730 (comment)
mobile

Capture.video.du.15-05-2024.15.58.50.webm

play video is laggy: can you please be more specific ? I could not reproduce it

Capture.video.du.15-05-2024.15.51.51.webm

cache location in desktop: on linux: temporary files are stored at /tmp but cache is at /home/<user>/.cache

Te-Z had a problem deploying to PR-1730 April 25, 2024 08:18 — with GitHub Actions Failure

hoangdat reviewed Apr 25, 2024

View reviewed changes

lib/pages/connect/connect_page_mixin.dart Outdated Show resolved Hide resolved

hoangdat reviewed Apr 25, 2024

View reviewed changes

pubspec.yaml Outdated Show resolved Hide resolved

Te-Z force-pushed the TW-1699/build_linux_version branch 2 times, most recently from 8201383 to 4d93694 Compare April 26, 2024 13:32

Te-Z temporarily deployed to PR-1730 April 26, 2024 13:32 — with GitHub Actions Inactive

Te-Z had a problem deploying to PR-1730 April 29, 2024 16:16 — with GitHub Actions Failure

Te-Z temporarily deployed to PR-1730 April 30, 2024 08:18 — with GitHub Actions Inactive

Te-Z temporarily deployed to PR-1730 April 30, 2024 08:37 — with GitHub Actions Inactive

Te-Z temporarily deployed to PR-1730 April 30, 2024 12:22 — with GitHub Actions Inactive

Te-Z and others added 8 commits May 6, 2024 15:26

TW-1699: app does start on linux

ede88d3

fixup! TW-1699: app does start on linux

bf0590d

TW-1699: PlatformInfos is desktop enabled

04216db

TW-1699: download attachment on desktop done

9beaebe

TW-1699: media viewers fixed

74fdc65

TW-1699: chat input shortcut fixed

71d03d3

TW-1699: send files ok

7ca19a8

TW-1699: change avatar updated

b7cec7a

Te-Z force-pushed the TW-1699/build_linux_version branch from 5e783c0 to b7cec7a Compare May 6, 2024 13:38

Te-Z temporarily deployed to PR-1730 May 6, 2024 13:38 — with GitHub Actions Inactive

fixup! TW-1699: change avatar updated

0272691

Te-Z temporarily deployed to PR-1730 May 6, 2024 13:42 — with GitHub Actions Inactive

Te-Z marked this pull request as ready for review May 6, 2024 13:43

Te-Z requested review from sherlockvn and dab246 as code owners May 6, 2024 13:43

Te-Z changed the title ~~[DRAFT] Build linux version~~ [Part 1] Build linux version May 6, 2024