[WAIT FOR DESIGN MOBILE] TW-1942: Change the design of log out dialog #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieutbui
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
tddang-linagora and
Te-Z
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1952 |
Pls check pipeline |
hieutbui
force-pushed
the
TW-1942-Change-design-of-log-out-dialog
branch
from
94fd5c8
to
88a6333
Compare
hieutbui
changed the title
Te-Z
approved these changes
Jul 18, 2024
KhaledNjim
reviewed
Jul 18, 2024
| @@ -3082,5 +3082,6 @@ | |||
| "byContinuingYourAgreeingToOur": "By continuing, you're agreeing to our", | |||
| "youDontHaveAnyContactsYet": "You dont have any contacts yet.", | |||
| "loading": "Loading...", | |||
| "errorDialogTitle": "Oops, something went wrong" | |||
| "errorDialogTitle": "Oops, something went wrong", | |||
| "logoutDialogWarning": "You will lose access to encrypted messages. We recommend that you enable chat backups before loggingout" | |||
There was a problem hiding this comment.
there is a missing space between "logging" and "out."
sherlockvn
reviewed
Jul 22, 2024
| child: Container( | ||
| constraints: BoxConstraints( | ||
| maxWidth: responsiveUtils.isMobile(context) | ||
| ? responsiveUtils.getSizeScreenWidth(context) - 48 |
There was a problem hiding this comment.
what if width of the screen is less than 48 ?
sherlockvn
reviewed
Jul 22, 2024
Comment on lines
+277
to
+290
| boxShadow: [ | ||
| BoxShadow( | ||
| color: Colors.black.withOpacity(0.15), | ||
| blurRadius: 8, | ||
| offset: const Offset(0, 4), | ||
| spreadRadius: 3, | ||
| ), | ||
| BoxShadow( | ||
| color: Colors.black.withOpacity(0.3), | ||
| blurRadius: 3, | ||
| offset: const Offset(0, 1), | ||
| ), | ||
| ], | ||
| ), |
There was a problem hiding this comment.
you should move it into style file
sherlockvn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Impact description
Test recommendations
Resolved
1942.mp4