-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-1774: Update avatar when have changes #1953
Open
sherlockvn
wants to merge
6
commits into
main
Choose a base branch
from
TW-1774/update-avatar-when-have-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+407
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
hieutbui,
tddang-linagora and
Te-Z
as code owners
July 16, 2024 09:30
nqhhdev
reviewed
Jul 16, 2024
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1953 |
Te-Z
approved these changes
Jul 17, 2024
sherlockvn
force-pushed
the
TW-1774/update-avatar-when-have-changes
branch
from
July 22, 2024 05:26
83c5f32
to
b54ea4e
Compare
Pls resolve conflicts. |
sherlockvn
force-pushed
the
TW-1774/update-avatar-when-have-changes
branch
from
July 22, 2024 10:19
b54ea4e
to
a48f3d2
Compare
Te-Z
approved these changes
Jul 24, 2024
Tested on android and chrome. LGTM |
nqhhdev
changed the title
Tw 1774/update avatar when have changes
TW-1774: Update avatar when have changes
Jul 25, 2024
nqhhdev
reviewed
Aug 15, 2024
Te-Z
reviewed
Aug 19, 2024
Te-Z
reviewed
Aug 19, 2024
Te-Z
reviewed
Aug 19, 2024
Te-Z
reviewed
Aug 19, 2024
Te-Z
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#1774
Root cause
If this is a bug, please provide a brief description of the root cause of the issue
Solution
Outline the implemented solution, detailing the changes made and how they address the issue
Impact description
If this is not a bug, please explain how the changes affect the project
Test recommendations
Recommendations for how to test this, or anything else you are worried about?
Pre-merge
Does anything else need to be done before merging?
Resolved
Attach screenshots or videos demonstrating the changes
Screen.Recording.2024-07-16.at.16.21.51.mov