Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tw 2001: No previews for video #2004

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Tw 2001: No previews for video #2004

merged 8 commits into from
Sep 4, 2024

Conversation

sherlockvn
Copy link
Collaborator

Ticket

#2001

Root cause

  • We accidentally upload the original file instead of thumbnail file
  • We do not use correct file mimeType for thumbnail

Solution

  • Upload original file -> thumbnail file
  • add mimeType for thumbnail when sending video

Test recommendations

Recommendations for how to test this, or anything else you are worried about?

  • Send video, image in multiple platform to see if have thumbnail or not

Resolved

Attach screenshots or videos demonstrating the changes

  • Android:
123.mov
  • Web:
456.mov
  • IOS:

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2004

@KhaledNjim
Copy link
Contributor

Worked well for mp4 videos but webm is not displayed properly

image

@sherlockvn
Copy link
Collaborator Author

Worked well for mp4 videos but webm is not displayed properly

image

this is expected behavior, because we can't display webp in the web platform

nqhhdev
nqhhdev approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@nqhhdev nqhhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sherlockvn sherlockvn force-pushed the TW-2001/no-previews-for-video branch from 2683dcb to 3781af6 Compare August 29, 2024 08:24
@sherlockvn sherlockvn force-pushed the TW-2001/no-previews-for-video branch from 3781af6 to 549c174 Compare August 29, 2024 08:27
@sherlockvn sherlockvn force-pushed the TW-2001/no-previews-for-video branch from 7f32c12 to 9376f27 Compare August 30, 2024 10:48
@hoangdat hoangdat merged commit 04da959 into main Sep 4, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-2001/no-previews-for-video branch September 4, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@Te-Z Te-Z Te-Z approved these changes

@nqhhdev nqhhdev nqhhdev approved these changes

@KhaledNjim KhaledNjim KhaledNjim approved these changes

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@hieutbui hieutbui Awaiting requested review from hieutbui hieutbui is a code owner

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora tddang-linagora is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sherlockvn @KhaledNjim @hoangdat @Te-Z @nqhhdev