TW-1996-removed-activated-status-in-accounts-tab #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaledNjim
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
hieutbui,
tddang-linagora and
Te-Z
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2005 |
nqhhdev
reviewed
Aug 29, 2024
nqhhdev
reviewed
Aug 29, 2024
lib/pages/new_private_chat/widget/expansion_contact_list_tile.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Sep 4, 2024
|
|
This ticket is only related to account status, the design updates will be implemented in a seperate ticket |
nqhhdev
reviewed
Sep 10, 2024
|
LGTM, please update the video demo @KhaledNjim |
updated |
hoangdat
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#1996
Root cause
Solution
According to the figma design only the Not-Activated status should be kept
Impact description
the activated status in contacts tab is removed
Test recommendations
Recommendations for how to test this, or anything else you are worried about?
Resolved
Attach screenshots or videos demonstrating the changes
2024-09-16.09-48-46.mp4
contacts_demo1.webm