Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PPT to latest version #151

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Update PPT to latest version #151

merged 2 commits into from
Oct 9, 2024

Conversation

jeremykubica
Copy link
Contributor

Mechanical application of PPT update

@jeremykubica jeremykubica requested a review from dougbrn October 9, 2024 17:50
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.47%. Comparing base (832848a) to head (4023f7d).
Report is 57 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          14       14           
  Lines         948      948           
=======================================
  Hits          943      943           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 9, 2024

Before [832848a] After [f1ca275] Ratio Benchmark (Parameter)
28.9±1ms 30.0±2ms 1.04 benchmarks.AssignSingleDfToNestedSeries.time_run
278M 284M 1.02 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
7.01±0.03ms 7.07±0.1ms 1.01 benchmarks.NestedFrameQuery.time_run
1.59±0.03ms 1.61±0.01ms 1.01 benchmarks.NestedFrameReduce.time_run
83.9M 83.8M 1 benchmarks.NestedFrameAddNested.peakmem_run
90.8M 90.8M 1 benchmarks.NestedFrameQuery.peakmem_run
87.5M 87.4M 1 benchmarks.NestedFrameReduce.peakmem_run
258M 256M 0.99 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
9.33±0.09ms 9.17±0.1ms 0.98 benchmarks.NestedFrameAddNested.time_run
56.6±3ms 54.7±1ms 0.97 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just requesting a few things be not added to the repository

src/nested_pandas/example_benchmarks.py Outdated Show resolved Hide resolved
docs/notebooks/README.md Outdated Show resolved Hide resolved
docs/pre_executed/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeremykubica jeremykubica merged commit 12d1293 into main Oct 9, 2024
9 checks passed
@jeremykubica jeremykubica deleted the ppt_update branch October 9, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants