Migrate Legacy Metadata Format to new Role-Based Format #1081
Conversation
Motivation: In line#1060, role-based authentication was introduced, changing the structure of metadata to support roles (READ, WRITE, ADMIN). Modifications: - Implemented a migration plugin to convert legacy metadata into the new role-based format. Result: - The legacy metadata format is migrated to new role-based format.
| } catch (Exception ex) { | ||
| // No need to rollback because the migration is not committed. Just log the error. | ||
| logger.warn("Failed to migrate metadata roles of {}", name, ex); | ||
| return UnmodifiableFuture.completedFuture(null); |
There was a problem hiding this comment.
Question)
- If a metadata is already migrated, will a
RedundantChangeExceptionbe thrown? - If an exception is thrown, would it be a better idea to log and continue instead of returning? Whether the metadata was migrated or not doesn't seem to affect the behavior.
There was a problem hiding this comment.
If a metadata is already migrated, will a RedundantChangeException be thrown?
Just the head revision is returned.
If an exception is thrown, would it be a better idea to log and continue instead of returning? Whether the metadata was migrated or not doesn't seem to affect the behavior.
Yeah, we can probably do that. Let me make a change. 😉
| for (Project project : context.projectManager().list().values()) { | ||
| final String name = project.name(); | ||
| try { | ||
| metadataService.migrateMetadata(name).join(); |
There was a problem hiding this comment.
Q) The blocking code will prevent other plugins from executing. Is that intentional?
There was a problem hiding this comment.
Is that intentional?
That is true. This approach is inspired by the mirroring migration job:
https://github.com/line/centraldogma/pull/880/files#diff-52b26e4b2cfaf28da0494ec3a92464b4b609594aeccb0a6f3c74d49a7454cf5cR135
| context.commandExecutor()); | ||
| final Stopwatch stopwatch = Stopwatch.createStarted(); | ||
| for (Project project : context.projectManager().list().values()) { | ||
| final String name = project.name(); |
There was a problem hiding this comment.
Should we add a migration log for each project so we can identify the progress and investegate when something goes wrong?
There was a problem hiding this comment.
It's a relatively simple migration so I thought just leaving the warning log was enough. 😄
Motivation:
In #1060, role-based authentication was introduced, changing the structure of metadata to support roles (READ, WRITE, ADMIN).
Modifications:
Result: