Move Mirroring Configuration to Individual Repositories #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will continue after #1085 is merged. 😉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
============================================
+ Coverage 70.29% 70.37% +0.08%
- Complexity 4284 4443 +159
============================================
Files 427 442 +15
Lines 17258 17882 +624
Branches 1915 1974 +59
============================================
+ Hits 12131 12585 +454
- Misses 4077 4240 +163
- Partials 1050 1057 +7 ☔ View full report in Codecov by Sentry. |
minwoox
changed the title
minwoox
commented
Jan 17, 2025
Comment on lines
+80
to
+87
| commandExecutor.execute(Command.updateServerStatus(ServerStatus.REPLICATION_ONLY)) | ||
| .get(1, TimeUnit.MINUTES); | ||
| logger.info("Starting Mirrors migration ..."); | ||
| if (commandExecutor instanceof ZooKeeperCommandExecutor) { | ||
| logger.debug("Waiting for 10 seconds to make sure that all cluster have been notified of the " + | ||
| "read-only mode ..."); | ||
| Thread.sleep(10000); | ||
| } |
There was a problem hiding this comment.
I prefer migrating without entering read-only mode because
- It's not critical if mirroring is temporarily unavailable for a minute.
- Any issues can be promptly addressed if they arise.
If this is acceptable, I will remove these lines of code. Please let me know your opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Mirroring configurations should belong to the repository where the mirroring is executed to ensure proper ownership and management alignment.
Modifications:
projects/foo/credentials/foo-credential.projects/foo/repos/bar/credentials/bar-credential.Result: