-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop using __LINE_BOT_SDK_PYTHON_VERSION__ (#710)
The string `__LINE_BOT_SDK_PYTHON_VERSION__ ` is used in `linebot/__about__.py` to make it easier to replace with the new version at the time of release. However, this string is inappropriate as a version, so it needs to be replaced when testing locally... This is cumbersome for us, so this PR addresses that issue. At the time of release, the file that need to be updated will be directly modified anyway. `./tools/update_version.py` will handle this. Since 1 lines across 1 files need to be changed, the CI will fail if this condition is not met. Reviewers can verify that the version is changed locally, but it's up to them whether to do so.
- Loading branch information
Showing
4 changed files
with
83 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import sys | ||
import re | ||
import subprocess | ||
|
||
def update_and_verify_version(new_version): | ||
file_path = 'linebot/__about__.py' | ||
|
||
# Update version | ||
with open(file_path, 'r') as file: | ||
content = file.read() | ||
|
||
new_content = re.sub( | ||
r"__version__ = '.*?'", | ||
f"__version__ = '{new_version}'", | ||
content | ||
) | ||
|
||
with open(file_path, 'w') as file: | ||
file.write(new_content) | ||
|
||
print(f"Updated version to {new_version} in {file_path}") | ||
|
||
# verify version | ||
match = re.search(r"__version__ = '(.*?)'", new_content) | ||
if not match: | ||
raise ValueError("Version string not found in the file.") | ||
|
||
actual_version = match.group(1) | ||
if actual_version != new_version: | ||
raise ValueError(f"Version mismatch: expected {new_version}, found {actual_version}") | ||
|
||
print(f"Version verified: {actual_version}") | ||
|
||
# diff check just in case | ||
try: | ||
result = subprocess.run(['git', 'diff', '--numstat', file_path], capture_output=True, text=True, check=True) | ||
changed_lines = result.stdout.strip().split('\n') | ||
added_lines = 0 | ||
deleted_lines = 0 | ||
|
||
for line in changed_lines: | ||
added, deleted = map(int, line.split('\t')[:2]) | ||
added_lines += added | ||
deleted_lines += deleted | ||
|
||
if added_lines != 1 or deleted_lines != 1: | ||
raise ValueError(f"Unexpected number of changed lines: expected 1 added and 1 deleted, found {added_lines} added and {deleted_lines} deleted") | ||
|
||
print('Git diff verification passed: 1 line added and 1 line deleted.') | ||
|
||
# Show diff | ||
diff_result = subprocess.run(['git', 'diff', '--color=always', file_path], capture_output=True, text=True, check=True) | ||
print('Git diff output:\n', diff_result.stdout) | ||
|
||
except subprocess.CalledProcessError as e: | ||
print(f"Error during git diff verification: {e}") | ||
sys.exit(1) | ||
|
||
if __name__ == "__main__": | ||
if len(sys.argv) != 2: | ||
print("Usage: python update_version.py <new_version>") | ||
sys.exit(1) | ||
|
||
new_version = sys.argv[1] | ||
|
||
try: | ||
update_and_verify_version(new_version) | ||
except ValueError as e: | ||
print(e) | ||
sys.exit(1) |