Report current_offset metric for incomplete partitions #830
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consumers of low volume topic-partitions, it can take a very long time for enough offset commits to happen before a partition is marked as "complete". For the `burrow_kafka_consumer_current_offset` metric to be reported, only a single committed offset is required.
andpol
commented
Sep 27, 2024
| firstOffset := len(partition.Offsets) - 1 | ||
| firstOffset := len(partition.Offsets) // defaults to the length, so if all offsets are nil we make an empty slice |
There was a problem hiding this comment.
Without this change, a runtime error: invalid memory address or nil pointer dereference was happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consumers of low volume topic-partitions, it can take a very long time for enough offset commits to happen before a partition is marked as "complete".
For the
burrow_kafka_consumer_current_offsetmetric to be reported, only a single committed offset is required.