Skip to content

Commit

Permalink
[CI] rename ci and add cron job for amd (#433)
Browse files Browse the repository at this point in the history
## Summary
<!--- This is a required section; please describe the main purpose of
this proposed code change. --->

<!---
## Details
This is an optional section; is there anything specific that reviewers
should be aware of?
--->

## Testing Done
<!--- This is a required section; please describe how this change was
tested. --->

<!-- 
Replace BLANK with your device type. For example, A100-80G-PCIe

Complete the following tasks before sending your PR, and replace `[ ]`
with
`[x]` to indicate you have done them. 
-->

- Hardware Type: <BLANK>
- [ ] run `make test` to ensure correctness
- [ ] run `make checkstyle` to ensure code style
- [ ] run `make test-convergence` to ensure convergence
  • Loading branch information
ByronHsu authored Dec 7, 2024
1 parent 189c411 commit ad656ee
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/amd-ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: GitHub Actions CI (AMD)
name: AMD GPU CI

on:
push:
Expand All @@ -10,9 +10,13 @@ on:
pull_request:
branches:
- main
# paths:
# - "src/**"
# - "test/**"
paths:
- "src/**"
- "test/**"
schedule:
# Runs at 00:00 UTC daily
- cron: '0 0 * * *'
workflow_dispatch: # Enables manual trigger

concurrency:
# This causes it to cancel previous in-progress actions on the same PR / branch,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml → .github/workflows/nvi-ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Modal GPU CI
name: NVIDIA GPU CI

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion test/transformers/test_cross_entropy.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
LigerCrossEntropyFunction,
liger_cross_entropy_kernel,
)
from liger_kernel.ops.utils import is_hip
from liger_kernel.transformers.cross_entropy import LigerCrossEntropyLoss
from liger_kernel.transformers.functional import liger_cross_entropy
from liger_kernel.utils import infer_device
from liger_kernel.ops.utils import is_hip

device = infer_device()
set_seed(42)
Expand Down
1 change: 0 additions & 1 deletion test/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ def get_batch_logps(
labels: Labels for which to compute the log probabilities. Label tokens with a value of ignore_index are ignored. Shape: (batch_size, sequence_length)
average_log_prob: If True, return the average log probability per (non-masked) token. Otherwise, return the sum of the log probabilities of the (non-masked) tokens.
is_encoder_decoder: Whether the model is an encoder-decoder model.
Returns:
A tensor of shape (batch_size,) containing the average/sum log probabilities of the given labels under the given logits.
"""
Expand Down

0 comments on commit ad656ee

Please sign in to comment.