Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weight support for LigerCrossEntropy #419

Closed
wants to merge 3 commits into from
Closed

Add weight support for LigerCrossEntropy #419

wants to merge 3 commits into from

Conversation

Tcc0403
Copy link
Collaborator

@Tcc0403 Tcc0403 commented Dec 2, 2024 •
edited
Loading

Summary

Resolve #404.

TODO:

  • (RFC) Expose weight paramter at LigerFusedLinearCrossEntropyLoss, but we need to consider renaming some variables to distinguish weight of linear layer and weight for ce.
  • Add unit test for FLCE after exposing weight

Testing Done

It hasn't fully tested with other params.

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@Tcc0403 Tcc0403 requested review from pramodith and ByronHsu December 2, 2024 12:41
@Tcc0403 Tcc0403 closed this Dec 2, 2024
@Tcc0403
Copy link
Collaborator Author

Tcc0403 commented Dec 2, 2024 •
edited
Loading

will open a PR with main repo's branch

@Tcc0403 Tcc0403 deleted the tcc/weight-ce branch December 2, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodith pramodith Awaiting requested review from pramodith

@ByronHsu ByronHsu Awaiting requested review from ByronHsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weighted Cross Entropy Loss
1 participant
@Tcc0403