Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linkerd-cni when using native sidecars #362

Merged
merged 1 commit into from
Apr 16, 2024

Commits on Apr 4, 2024

  1. Fix linkerd-cni when using native sidecars

    Fixes linkerd/linkerd2#11597
    
    When the cni plugin is triggered, it validates that the proxy has been
    injected into the pod before setting up the iptables rules. It does so
    by looking for the "linkerd-proxy" container. However, when the proxy is
    injected as a native sidecar, it gets added as an _init_ container, so
    it was being disregarded here.
    
    We don't have integration tests for validating native sidecars when
    using linkerd-cni because [Calico doesn't work in k3s since k8s
    1.27](k3d-io/k3d#1375), and we require k8s
    1.29 for using native sidecars.
    I did nevertheless successfully test this fix in an AKS cluster.
    alpeb committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d1edb48 View commit details
    Browse the repository at this point in the history